Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: unite channel tests into single GHA matrix workflows #32876

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

mxschmitt
Copy link
Member

No description provided.

strategy:
fail-fast: false
matrix:
channel: [chrome, chrome-beta, msedge, msedge-beta, msedge-dev]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively we create the matrix ourselves using:

- channel: chrome
runs-on: ubuntu-20.04
- channel: chrome
runs-on: macos-latest
- channel: chrome
runs-on: windows-latest

- channel: chrome-beta
runs-on: ubuntu-20.04
- channel: chrome-beta
runs-on: macos-latest
- channel: chrome-beta
runs-on: windows-latest

- channel: msedge
runs-on: ubuntu-20.04
- channel: msedge
runs-on: macos-latest
- channel: msedge
runs-on: windows-latest

- channe: msedge-beta
runs-on: ubuntu-20.04
- channe: msedge-beta
runs-on: macos-latest
- channe: msedge-beta
runs-on: windows-latest

- channel: msedge-dev
runs-on: ubuntu-20.04
- channel: msedge-dev
runs-on: macos-latest
- channel: msedge-dev
runs-on: windows-latest

not sure if we need the fine grade control, probably not and this is fine?

.github/workflows/tests_secondary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_secondary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_secondary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_secondary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_secondary.yml Outdated Show resolved Hide resolved
mxschmitt and others added 3 commits September 30, 2024 13:26
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>

This comment has been minimized.

@mxschmitt mxschmitt added the CQ1 label Sep 30, 2024

This comment has been minimized.

Copy link
Contributor

Test results for "tests others"

1 flaky ⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:188:5 › should watch component

20720 passed, 538 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium] › components/splitView.spec.tsx:35:5 › should render sidebar first
⚠️ [webkit-page] › page/workers.spec.ts:245:3 › should support offline

36408 passed, 758 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit dde8090 into microsoft:main Sep 30, 2024
104 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants